Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python versions: drop 3.8, add 3.13 to CI #206

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Update Python versions: drop 3.8, add 3.13 to CI #206

merged 2 commits into from
Jan 29, 2025

Conversation

antoinevg
Copy link
Member

No description provided.

@mossmann mossmann requested a review from miek January 28, 2025 15:23
miek
miek requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@miek miek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The importlib workarounds shared.py and commands/util.py can be removed now.

@antoinevg
Copy link
Member Author

Oh nice, I'd completely forgotten about that. Thanks @miek!

@antoinevg antoinevg requested a review from miek January 29, 2025 11:45
@antoinevg antoinevg force-pushed the antoinevg/bump-python-39 branch from 88b83f2 to fe5822c Compare January 29, 2025 11:46
@antoinevg antoinevg merged commit ec448a6 into greatscottgadgets:main Jan 29, 2025
18 checks passed
@antoinevg antoinevg deleted the antoinevg/bump-python-39 branch January 29, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miek miek miek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinevg @miek