Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add USB analysis tutorial #187

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

miek
Copy link
Member

@miek miek commented Sep 24, 2024

@mossmann mossmann requested a review from martinling September 24, 2024 16:08
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! I suggest a few small changes.

docs/source/tutorial_usb_analysis.rst Outdated Show resolved Hide resolved
docs/source/tutorial_usb_analysis.rst Outdated Show resolved Hide resolved
docs/source/tutorial_usb_analysis.rst Outdated Show resolved Hide resolved
Copy link
Member

@martinling martinling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. One small note.

docs/source/tutorial_usb_analysis.rst Outdated Show resolved Hide resolved
@miek miek force-pushed the usb_analysis_tutorial branch from d0b82c7 to f0f0e81 Compare September 26, 2024 14:26
@miek miek requested a review from mossmann September 26, 2024 14:59
@mossmann mossmann merged commit 04621bd into greatscottgadgets:main Sep 26, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants