Add WCID descriptors to Moondancer #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinevg
force-pushed
the
antoinevg/moondancer-wcid-descriptors
branch
6 times, most recently
from
62d9463 to
8c9a6c5
Compare
antoinevg
force-pushed
the
antoinevg/moondancer-wcid-descriptors
branch
from
8c9a6c5 to
bd7aa29
Compare
mndza
reviewed
Aug 20, 2024
| pub const fn new() -> Self { | ||
| Self { | ||
| bFirstInterfaceNumber: 0, | ||
| bReserved: 0x01, // TODO does this _need_ to be 0x01 ??? |
There was a problem hiding this comment.
It should be 0x01 according to the spec.
mndza
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.