Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont flash unsupported firmware. #167

Conversation

antoinevg
Copy link
Member

Apollo firmware hardware detection only works for Cynthion hardware revisions >=r0.6.

This PR will abort any requested update process and display a helpful message.

@antoinevg antoinevg marked this pull request as ready for review August 12, 2024 08:40
@antoinevg antoinevg requested a review from mossmann August 12, 2024 08:42
@mossmann mossmann marked this pull request as draft August 16, 2024 15:47
@mossmann
Copy link
Member

I've changed this to a draft as it will need to be rebased after #166.

@antoinevg antoinevg force-pushed the antoinevg/dont-flash-unsupported-firmware branch from 1224299 to f515b3c Compare August 27, 2024 19:08
@antoinevg antoinevg marked this pull request as ready for review August 27, 2024 19:08
Copy link
Member

@mossmann mossmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mossmann mossmann merged commit 1200079 into greatscottgadgets:main Aug 28, 2024
18 checks passed
@antoinevg antoinevg deleted the antoinevg/dont-flash-unsupported-firmware branch October 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants