Skip to content

Commit

Permalink
Merge pull request #199 from Folleah/patch-1
Browse files Browse the repository at this point in the history
Fix dependency incompatibility
  • Loading branch information
gre authored Mar 6, 2019
2 parents 9caa300 + 5610ebb commit 4a01cbf
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

buildscript {
/* In case of submodule usage, do not try to apply own repositories and plugins,
root project is responsible for that. */
Expand All @@ -15,12 +19,12 @@ buildscript {
apply plugin: 'com.android.library'

android {
compileSdkVersion 27
buildToolsVersion "28.0.3"
compileSdkVersion safeExtGet('compileSdkVersion', 27)
buildToolsVersion safeExtGet('buildToolsVersion', '28.0.3')

defaultConfig {
minSdkVersion 16
targetSdkVersion 27
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 27)

versionCode 1
versionName "1.0"
Expand All @@ -42,7 +46,6 @@ repositories {
}

dependencies {
implementation 'com.android.support:support-v4:27.+'

implementation "com.android.support:support-v4:${safeExtGet('supportLibVersion', '27.+')}"
api 'com.facebook.react:react-native:+'
}
}

0 comments on commit 4a01cbf

Please sign in to comment.