Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: grpc client for tap aggregator #583

Merged
merged 24 commits into from
Jan 24, 2025
Merged

feat: grpc client for tap aggregator #583

merged 24 commits into from
Jan 24, 2025

Conversation

gusinacio
Copy link
Member

No description provided.

pedrohba1 and others added 23 commits January 24, 2025 17:49
@pedrohba1 @gusinacio
feat: remove jsonrpc client in favor of grpc client
d601187 
Co-authored-by: Gustavo Inacio <[email protected]>
Signed-off-by: pedro bufulin <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@pedrohba1 @gusinacio
refactor: adjust endpoint in test
78aa4ba
@pedrohba1 @gusinacio
chore: cargo fmt
20052b9
@pedrohba1 @gusinacio
refactor: remove commented code and unnecessary stop of handler in test
b6ea2a7
@pedrohba1 @gusinacio
test: handle error from failed connection
c86e1e0
@pedrohba1 @gusinacio
feat: log out endpoint in case of failed connection attempt
d8154d3
@pedrohba1 @gusinacio
ci: add TapAggregator server mock to minimize changes to tests
6e426f6
@pedrohba1 @gusinacio
ci: fix line indent
910f25f
@pedrohba1 @gusinacio
ci: force ri rerun
f680606
@pedrohba1 @gusinacio
refactor: cargo fmt
ea023cf
@pedrohba1 @gusinacio
ci: move mock server start to test-and-coverage
8c2bdb5
@pedrohba1 @gusinacio
test: test aggregator server helper function
34d2947
@pedrohba1 @gusinacio
test: instantiate server instead of using mock
36ecace
@pedrohba1 @gusinacio
ci: remove unnecessary step
90e2e3f
@pedrohba1 @gusinacio
refactor: correct typo
990340a
@pedrohba1 @gusinacio
refactor: correct typo
eb13c2b
@pedrohba1 @gusinacio
refactor: replace space
54fcc58
@pedrohba1 @gusinacio
refactor: remove unnecessary message
bcec5b5
@gusinacio
test: fix hanging test
d99ca12 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
refactor: change expect with context
30be4a0 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: use get_grpc_url() to spawn a grpc
ce3206f 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: use server_url directly
26ac63b 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio
test: update all tests to use get_grpc_url
87dab30 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/grpc-client branch from 0cc5f02 to 87dab30 Compare January 24, 2025 16:49
@gusinacio gusinacio marked this pull request as ready for review January 24, 2025 17:02
@gusinacio gusinacio changed the title Gustavo/grpc client feat: grpc client for tap aggregator Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 12953910672

Details

  • 59 of 70 (84.29%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 77.579%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/test.rs 24 25 96.0%
crates/tap-agent/src/agent/sender_account.rs 9 13 69.23%
crates/tap-agent/src/agent/sender_allocation.rs 21 27 77.78%
Files with Coverage Reduction New Missed Lines %
crates/service/src/tap/checks/deny_list_check.rs 2 94.4%
Totals Coverage Status
Change from base Build 12873556131: 0.02%
Covered Lines: 6820
Relevant Lines: 8791
💛 - Coveralls

pedrohba1
pedrohba1 approved these changes Jan 24, 2025
View reviewed changes
crates/tap-agent/src/test.rs Show resolved Hide resolved
@gusinacio gusinacio merged commit c3ede8f into main Jan 24, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/grpc-client branch January 24, 2025 18:15
@gusinacio gusinacio mentioned this pull request Jan 24, 2025
Closed
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchapalaver suchapalaver suchapalaver approved these changes

@pedrohba1 pedrohba1 pedrohba1 approved these changes

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gusinacio @pedrohba1 @suchapalaver