Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain headers in attestation middleware #577

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Jan 15, 2025

The indexer-service has not been properly forwarding the graph-indexed header because the attestation middleware discarded all headers set by the handler.

@Theodus Theodus requested a review from gusinacio January 15, 2025 20:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12796849680

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 77.586%

Totals Coverage Status
Change from base Build 12748006443: 0.005%
Covered Lines: 6802
Relevant Lines: 8767

💛 - Coveralls

Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 0d76f35 into main Jan 15, 2025
10 checks passed
@gusinacio gusinacio deleted the theodus/headers branch January 15, 2025 21:28
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants