Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tap-agent): make RAV table sequelize-friendly #123

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

aasseman
Copy link
Contributor

By adding the createdAt and updatedAt columns.
Sequelize is used in indexer-agent, and it needs to access the RAV table to redeem RAVs.

See https://sequelize.org/docs/v6/core-concepts/model-basics/#timestamps

@aasseman aasseman added size:small Small p1 High priority labels Feb 21, 2024
@aasseman aasseman self-assigned this Feb 21, 2024
By adding the `createdAt` and `updatedAt` columns.
Sequelize is used in indexer-agent, and it needs to access the RAV table to redeem RAVs.
See https://sequelize.org/docs/v6/core-concepts/model-basics/#timestamps

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman force-pushed the aasseman/rav_table_sequelize_friendly branch from 7e183e0 to 6687215 Compare February 21, 2024 00:50
@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 8023391392

Details

  • 0 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 65.019%

Totals Coverage Status
Change from base Build 7979080219: 0.06%
Covered Lines: 2855
Relevant Lines: 4391

💛 - Coveralls

To please sequelize...

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman force-pushed the aasseman/rav_table_sequelize_friendly branch from b5f36ba to 955473f Compare February 21, 2024 23:24
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit 1e07510 into main Feb 26, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/rav_table_sequelize_friendly branch February 26, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:small Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants