Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator info endpoint to return an object #121

Merged
merged 2 commits into from
Feb 20, 2024
Merged

operator info endpoint to return an object #121

merged 2 commits into from
Feb 20, 2024

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Feb 12, 2024 •
edited
Loading

update from Json(address) to more like the existing format of Json(operator: address)
Addressing #120 (comment)

@coveralls
Copy link

coveralls commented Feb 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7872927052

Details

  • -3 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 63.009%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 7856562898: -0.02%
Covered Lines: 2446
Relevant Lines: 3882
💛 - Coveralls

@hopeyen hopeyen requested a review from Jannis February 12, 2024 13:59
@hopeyen hopeyen self-assigned this Feb 12, 2024
@hopeyen hopeyen added size:small Small p1 High priority type:bug Something isn't working p2 Medium priority and removed p1 High priority labels Feb 12, 2024
@hopeyen hopeyen merged commit 5125251 into main Feb 20, 2024
8 checks passed
@hopeyen hopeyen deleted the hope/operator-info-endpoint branch February 20, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

@Jannis Jannis Awaiting requested review from Jannis

Assignees

@hopeyen hopeyen

Labels
p2 Medium priority size:small Small type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hopeyen @coveralls @aasseman