Fix reorg threshold bug #5804
Open
Fix reorg threshold bug #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
force-pushed
the
zoran/fix-reorg-threshold-bug
branch
from
3c10aba to
51023d2
Compare
zorancv
force-pushed
the
zoran/fix-reorg-threshold-bug
branch
from
a313261 to
4c21ffe
Compare
lutter
approved these changes
Mar 4, 2025
| } else { | ||
| self.reorg_threshold | ||
| } | ||
| } |
There was a problem hiding this comment.
This is pretty minor, but AFAICT, we only need the ability to override the reorg threshold when debug assertions is on. Could we therefore have a variant of this function for #[cfg(not(debug_assertions))] that doesn't touch the mutex?
| @@ -109,6 +109,8 @@ fn assert_eq_ignore_backtrace(err: &SubgraphError, expected: &SubgraphError) { | |||
|
|
|||
| #[tokio::test] | |||
| async fn data_source_revert() -> anyhow::Result<()> { | |||
| *TEST_WITH_NO_REORG.lock().unwrap() = true; | |||
|
|
|||
There was a problem hiding this comment.
I am not entirely sure if these tests are run in parallel or not. But it might be better to reset TEST_WITH_NO_REORG after this test is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.