Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix graphman deploy command logic when creating subgraph #5740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix graphman deploy command logic when creating subgraph #5740

wants to merge 1 commit into from

Conversation

shiyasmohd
Copy link
Contributor

Fixes #5739

@shiyasmohd shiyasmohd self-assigned this Dec 28, 2024
@shiyasmohd shiyasmohd requested a review from incrypto32 January 3, 2025 14:03
@lutter
Copy link
Collaborator

lutter commented Mar 5, 2025

I wonder if the current or the new behavior is really what users want. IMHO, names are mostly annoying, and I think it would be nicer/easier if graphman deploy <name> <hash> just created the name if it doesn't exist yet and we'd get rid of the --create flag altogether. Thoughts?

@shiyasmohd
Copy link
Contributor Author

Yes. That would be better. Thanks for the suggestion. I'll update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incrypto32 incrypto32 Awaiting requested review from incrypto32

At least 1 approving review is required to merge this pull request.

Assignees

@shiyasmohd shiyasmohd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] graphman deploy shows deployed even if subgraph was not deployed
2 participants
@shiyasmohd @lutter