Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: consolidate unit/e2e test code #908

Merged
merged 13 commits into from
Jan 15, 2024
Merged

test: consolidate unit/e2e test code #908

merged 13 commits into from
Jan 15, 2024

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Jan 10, 2024 •
edited
Loading

Changes

  • Simplify e2e scripts
  • Consolidate how e2e and unit tests deploy and configure the protocol
  • Refactor deployment hardhat tasks

@tmigone tmigone changed the title Tmigone/deploy consolidate Consolidate unit/e2e test code Jan 10, 2024
@tmigone tmigone force-pushed the tmigone/upgrade-test-revamp branch from d42adf2 to f27cdff Compare January 10, 2024 19:37
@tmigone tmigone force-pushed the tmigone/deploy-consolidate branch from e27da9e to 78c2b3e Compare January 10, 2024 19:40
@tmigone tmigone linked an issue Jan 10, 2024 that may be closed by this pull request
fix: ensure all deploy/config alternatives use the same code #905
Closed
@tmigone tmigone changed the title Consolidate unit/e2e test code test: consolidate unit/e2e test code Jan 11, 2024
@tmigone tmigone requested review from pcarranzav and Maikol January 11, 2024 16:19
@tmigone tmigone force-pushed the tmigone/upgrade-test-revamp branch from f27cdff to 516a813 Compare January 12, 2024 15:42
@tmigone tmigone force-pushed the tmigone/deploy-consolidate branch from c891741 to 7221dad Compare January 12, 2024 15:46
@tmigone
fix: hh migrate task
0efbe25 
Signed-off-by: Tomás Migone <[email protected]>
Maikol
Maikol previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Maikol Maikol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from tmigone/upgrade-test-revamp to main January 15, 2024 18:22
@tmigone tmigone dismissed Maikol’s stale review January 15, 2024 18:22

The base branch was changed.

@tmigone tmigone merged commit b4d918b into main Jan 15, 2024
4 of 6 checks passed
@tmigone tmigone deleted the tmigone/deploy-consolidate branch January 15, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maikol Maikol Maikol approved these changes

@pcarranzav pcarranzav Awaiting requested review from pcarranzav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ensure all deploy/config alternatives use the same code
2 participants
@tmigone @Maikol