fix: set and hardcode minimum L2 curation to 1 GRT, enforce it in all cases, allow sub-epoch collect (OZ H-01) #874
+174
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cases, allow sub-epoch collect
fix: set and hardcode minimum L2 curation to 1 GRT, enforce it in all cases, allow sub-epoch collect (OZ H-01)
🚨 Vulnerabilities Summary
For more details view the full report in OpenZeppelin Code |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pcv/require-epoch-for-collect #874 +/- ##
=================================================================
+ Coverage 92.59% 92.62% +0.02%
=================================================================
Files 47 47
Lines 2364 2372 +8
Branches 432 434 +2
=================================================================
+ Hits 2189 2197 +8
Misses 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Maikol
approved these changes
Nov 8, 2023
pcarranzav
changed the title
tmigone
reviewed
Nov 13, 2023
|
|
||
| // Get the amount of tokens to refund based on returned signal | ||
| uint256 tokensOut = signalToTokens(_subgraphDeploymentID, _signalIn); | ||
|
|
||
| if (previousCuratorSignal > _signalIn) { |
There was a problem hiding this comment.
pedantic nit, this could be previousCuratorSignal != _signalIn and save a little gas. Though not sure how you feel about code readability.
There was a problem hiding this comment.
Good point, but yeah for now I'll leave it like this for readability
tmigone
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.