-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(SubgraphService): allow force closing over allocated allocations #1044
Merged
Maikol
merged 3 commits into
horizon
from
mde/subgraph-service-force-close-over-allocated
Oct 1, 2024
Merged
chore(SubgraphService): allow force closing over allocated allocations #1044
Maikol
merged 3 commits into
horizon
from
mde/subgraph-service-force-close-over-allocated
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigone
requested changes
Sep 19, 2024
packages/subgraph-service/contracts/utilities/AllocationManager.sol
Outdated
Show resolved
Hide resolved
packages/subgraph-service/contracts/interfaces/ISubgraphService.sol
Outdated
Show resolved
Hide resolved
chore(SubgraphService): allow force closing over allocated allocations
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Maikol
force-pushed
the
mde/subgraph-service-force-close-over-allocated
branch
from
September 20, 2024 16:27
2b58ade
to
6590d4e
Compare
tmigone
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits
packages/subgraph-service/contracts/interfaces/ISubgraphService.sol
Outdated
Show resolved
Hide resolved
tmigone
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩵
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.