Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reorder parameter use in mulPPM function call in mulPPMRoundUp function. (OZ N-12) #1043

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

MoonBoi9001
Copy link
Member

Motivation:

Title and details found from the above link.

Key changes

  • Order of parameter use changed from (MAX_PPM - b, a) to (a, MAX_PPM - b)

Copy link

fix: reorder parameter use in mulPPM function call in mulPPMRoundUp function. (OZ N-12)

Generated at commit: 79f7828bb96c76524c3e07e8fd87a713695ea916

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
41
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@MoonBoi9001 MoonBoi9001 merged commit 613d7f3 into horizon Sep 19, 2024
7 checks passed
@MoonBoi9001 MoonBoi9001 deleted the fix_oz_n-12 branch September 19, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants