fix: remove unused return values. (OZ N-10) #1040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Title:
N-10 Redundant Return Values
Details:
Throughout the codebase, multiple instances of functions with unused return values were identified:
The _closeAllocation function of the AllocationManager contract
The presentPOI, clearPendingRewards, close, and snapshotRewards functions of the Allocation library
Consider removing these unused return values to simplify the code and improve readability, ensuring that functions only return values that are actively utilized by their callers.
Key changes
_closeAllocation
function of the AllocationManager contract.presentPOI
,clearPendingRewards
,close
, andsnapshotRewards
functions function of the Allocation library.