fix: approving collector for smaller allowance

graphprotocol · May 22, 2024 · b20cc18 · b20cc18
1 parent 1981324
commit b20cc18
Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/horizon/contracts/payments/PaymentsEscrow.sol b/packages/horizon/contracts/payments/PaymentsEscrow.sol
@@ -82,8 +82,13 @@ contract PaymentsEscrow is Multicall, GraphDirectory, IPaymentsEscrow {
 
     // approve a data service to collect funds
     function approveCollector(address dataService, uint256 amount) external {
-        authorizedCollectors[msg.sender][dataService].authorized = true;
-        authorizedCollectors[msg.sender][dataService].amount = amount;
+        IGraphEscrow.Collector storage collector = authorizedCollectors[msg.sender][dataService];
+        if (collector.amount > amount) {
+            revert GraphEscrowCollectorInsufficientAmount(collector.amount, amount);
+        }
+
+        collector.authorized = true;
+        collector.amount = amount;
         emit AuthorizedCollector(msg.sender, dataService);
     }
 

diff --git a/packages/horizon/test/escrow/collector.t.sol b/packages/horizon/test/escrow/collector.t.sol
@@ -15,6 +15,16 @@ contract GraphEscrowCollectorTest is GraphEscrowTest {
         assertEq(thawEndTimestamp, 0);
     }
 
+    function testCollector_RevertWhen_ApprovingForSmallerAllowance(
+        uint256 amount,
+        uint256 smallerAmount
+    ) public useGateway useCollector(amount) {
+        vm.assume(smallerAmount < amount);
+        bytes memory expectedError = abi.encodeWithSignature("GraphEscrowCollectorInsufficientAmount(uint256,uint256)", amount, smallerAmount);
+        vm.expectRevert(expectedError);
+        escrow.approveCollector(users.verifier, smallerAmount);
+    }
+
     // Collector thaw tests
 
     function testCollector_Thaw(uint256 amount) public useGateway useCollector(amount) {