Skip to content

Commit

Permalink
Add a test for multiple registrations of the same name of gauge (micr…
Browse files Browse the repository at this point in the history
  • Loading branch information
izeye authored and shakuzen committed Mar 11, 2019
1 parent 672466d commit 6ae5efd
Showing 1 changed file with 15 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@

import static org.assertj.core.api.Assertions.assertThat;

/**
* Tests for {@link MeterRegistry}.
*
* @author Jon Schneider
* @author Johnny Lim
*/
class MeterRegistryTest {
private MeterRegistry registry = new SimpleMeterRegistry();

Expand All @@ -45,7 +51,7 @@ public MeterFilterReply accept(Meter.Id id) {
}

@Test
void overidingAcceptMeterFilter() {
void overridingAcceptMeterFilter() {
registry.config().meterFilter(MeterFilter.accept(m -> m.getName().startsWith("jvm.important")));
registry.config().meterFilter(MeterFilter.deny(m -> m.getName().startsWith("jvm")));

Expand Down Expand Up @@ -97,4 +103,12 @@ void noopMetersAfterRegistryClosed() {
assertThat(registry.timer("my.timer.before")).isNotInstanceOf(NoopTimer.class);
assertThat(registry.timer("my.timer.after")).isInstanceOf(NoopTimer.class);
}

@Test
void gaugeRegistersGaugeOnceAndSubsequentGaugeCallsWillNotRegister() {
registry.gauge("my.gauge", 1d);
registry.gauge("my.gauge", 2d);

assertThat(registry.get("my.gauge").gauge().value()).isEqualTo(1d);
}
}

0 comments on commit 6ae5efd

Please sign in to comment.