Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Grails 6.1.1 #521

Merged
merged 25 commits into from
Oct 3, 2024
Merged

Updating to Grails 6.1.1 #521

merged 25 commits into from
Oct 3, 2024

Conversation

jdaugherty
Copy link
Contributor

Updating to Grails 6.1.1.

@jdaugherty
Copy link
Contributor Author

@jamesfredley this was my initial pass at merging my changes to support grails 6. Once we have an initial review done, I'll iterate on the build actions to get them working end-to-end.

@jdaugherty
Copy link
Contributor Author

Per discussion, the testapp-profile was used as part of the old travis CI testing. It looks like the test run there used to:

  1. Build the project & install into local maven
  2. Use grails profile to generate various test apps

Other than generating the grails apps, I can't see where those apps were ever used. I assume they were used for manual testing. It also looks like past github CI's only ever ran gradle check and published all of the gradle projects except spring-security-rest-testapp-profile.

Running gradle build at the root will treat the testapp-profile as a grails project - likely because grails-shell was originally removed in later versions of grails. This build will fail due to the same reason grails/grails-gradle-plugin#316 was created. For now, I'm going to remove the gradle project spring-security-rest-testapp-profile since we haven't tested with it since 2020 and because there are old secrets for APIs that aren't even valid anymore.

We can always restore this subproject later if we get profiles working correctly.

@matrei matrei self-requested a review September 30, 2024 13:10
Copy link

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be reason to go back and look at the workflows, but we'll notice that later if there is a problem.

Maybe update the license headers of changed files with current year and original author or authors

settings.gradle Outdated Show resolved Hide resolved
.github/workflows/gradle.yml Outdated Show resolved Hide resolved
.github/workflows/gradle.yml Outdated Show resolved Hide resolved
settings.gradle Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gradle.properties Show resolved Hide resolved
@jdaugherty jdaugherty merged commit 8f970e7 into grails:5.0.x Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants