Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert Merge branch '7.0.x' into 6.2.x #501

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Oct 3, 2024

This was caused by the github resolve merge conflict bug when merging changes up which results in the changes from the target branch also being merged into the source branch for the merge.

@jdaugherty
Copy link
Contributor

I ran git diff 6.1.x..fix-accidental-merge-7.0.x-into-6.2.x to check the revert of this merge.

The changes consist of:

  1. action updates for the gradle enterprise key
  2. updating gradle publish plugin from 1.3 to 2.0 (believe related to g:render with body and g:set bug #1 & publishing fixes we made for 6.2.x)
  3. version increments to 6.2.x
  4. Improvement to RenderTagLib for the details class specification (scott did this one)
  5. adding the namespace as a variable to the gsp
    I think this looks good as a result.

@jdaugherty
Copy link
Contributor

I think we may be missing another change by scott, there are build failures.

Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version mismatch seems to have fixed the remaining issues.

@jamesfredley jamesfredley changed the title revert github resolve merge conflict bug that resulted in 7.0.x merge into 6.2.x branch revert Merge branch '7.0.x' into 6.2.x Oct 3, 2024
@jamesfredley jamesfredley merged commit fc4e2a3 into 6.2.x Oct 3, 2024
10 checks passed
@jamesfredley jamesfredley deleted the fix-accidental-merge-7.0.x-into-6.2.x branch October 3, 2024 14:47
jdaugherty added a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants