Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comma in tag values through cli flag #4541

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

mstoykov
Copy link
Contributor

What?

Support setting tags which values contain commas through cli flags

Why?

It seems very strange that this isn't supported at all on the cli, but you can do it through options.

This is a breaking change as before you can do --tag one=value,two=value which will produce 2 flags one with key one, the other with two.

This will now produce only 1 tag.

I would argue though that the alternative is to forbid commas in the values. And that seems like a bigger breaking change.

Given our documentation and help we have never documented that you can put two tags with the same flag, so 🤷

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added ux breaking change for PRs that need to be mentioned in the breaking changes section of the release notes labels Feb 12, 2025
@mstoykov mstoykov added this to the v1.0.0-rc1 milestone Feb 12, 2025
@mstoykov mstoykov requested a review from a team as a code owner February 12, 2025 09:11
@mstoykov mstoykov requested review from inancgumus and olegbespalov and removed request for a team February 12, 2025 09:11
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Producing one tag sounds more intuitive.

@mstoykov mstoykov merged commit b8e7f9a into master Feb 14, 2025
28 checks passed
@mstoykov mstoykov deleted the supportCommaInTags branch February 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants