Support comma in tag values through cli flag #4541
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Support setting tags which values contain commas through cli flags
Why?
It seems very strange that this isn't supported at all on the cli, but you can do it through options.
This is a breaking change as before you can do
--tag one=value,two=value
which will produce 2 flags one with keyone
, the other withtwo
.This will now produce only 1 tag.
I would argue though that the alternative is to forbid commas in the values. And that seems like a bigger breaking change.
Given our documentation and help we have never documented that you can put two tags with the same flag, so 🤷
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)