[grafana] Enabling the ability to omit the REQ_USERNAME and REQ_PASSWORD variables when sidecar.dashboards.skipReload is true #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nment variables when sidecar.dashboards.skipReload is true Signed-off-by: Steven Bambling <[email protected]>
smbambling
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
zanhsieh
changed the title
zanhsieh
approved these changes
Jul 16, 2023
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Jul 16, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [grafana](https://grafana.net) ([source](https://togithub.com/grafana/helm-charts)) | patch | `6.58.3` -> `6.58.4` | --- ### Release Notes <details> <summary>grafana/helm-charts (grafana)</summary> ### [`v6.58.4`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-6.58.4) [Compare Source](https://togithub.com/grafana/helm-charts/compare/grafana-6.58.3...grafana-6.58.4) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Enabling the ability to omit the REQ_USERNAME and REQ_PASSWORD variables when sidecar.dashboards.skipReload is true by [@​smbambling](https://togithub.com/smbambling) in [https://github.com/grafana/helm-charts/pull/2495](https://togithub.com/grafana/helm-charts/pull/2495) #### New Contributors - [@​smbambling](https://togithub.com/smbambling) made their first contribution in [https://github.com/grafana/helm-charts/pull/2495](https://togithub.com/grafana/helm-charts/pull/2495) **Full Changelog**: grafana/helm-charts@oncall-1.3.12...grafana-6.58.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
doonga
referenced
this pull request
in doonga/greyrock-ops
Jul 16, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [grafana](https://grafana.net) ([source](https://togithub.com/grafana/helm-charts)) | patch | `6.58.3` -> `6.58.4` | --- ### Release Notes <details> <summary>grafana/helm-charts (grafana)</summary> ### [`v6.58.4`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-6.58.4) [Compare Source](https://togithub.com/grafana/helm-charts/compare/grafana-6.58.3...grafana-6.58.4) The leading tool for querying and visualizing time series and metrics. #### What's Changed - \[grafana] Enabling the ability to omit the REQ_USERNAME and REQ_PASSWORD variables when sidecar.dashboards.skipReload is true by [@​smbambling](https://togithub.com/smbambling) in [https://github.com/grafana/helm-charts/pull/2495](https://togithub.com/grafana/helm-charts/pull/2495) #### New Contributors - [@​smbambling](https://togithub.com/smbambling) made their first contribution in [https://github.com/grafana/helm-charts/pull/2495](https://togithub.com/grafana/helm-charts/pull/2495) **Full Changelog**: grafana/helm-charts@oncall-1.3.12...grafana-6.58.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: greyrock-bot <112729691+greyrock-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the k8s-sidecar container will always use basic authentication when REQ_USERNAME and REQ_PASSWORD are set. This can cause issues when attempting to use any configmaps/secrets with
*.urlkey configured.There is an open bug issue here: kiwigrid/k8s-sidecar#290
However when
sidecar.dashboards.skipReloadis true there doesn't seem to be a need/reason to set the REQ_USERNAME and REQ_PASSWORD environment variables. This PR allow omitting them to prevent triggering the current bug in the k8s-sidecar.This issue was triggered by the following commit inside this repository: 3bcfc47