Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Add new attributs and methods for bar_gauge_panel #275

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Basti3n
Copy link

@Basti3n Basti3n commented Sep 24, 2020

Hello,

Here are some new attributs to add to the bar_gauge_panel.

Here is an exemple of usage of some of them :

bar_gauge_panel.new('Data',
    datasource=datasource,
    reductionFunc='last',
    options_min=1,
    options_max=50,
    options_orientation='horizontal',
    pluginVersion="6.5.1"
    )
    .addThreshold({color: "green",value: null})
    .addThreshold({color: "#EAB839",value: 40})
    .addThreshold({color: "red",value: 45})
    .addMapping({"from": "","id": 1,"operator": "","text": "No File","to": "","type": 1,"value": "0"})

@Basti3n
Copy link
Author

Basti3n commented Sep 25, 2020

Does someone knows why my unit test keeps failing ?

@insignias
Copy link

Does someone knows why my unit test keeps failing ?

Formatting ./grafonnet/bar_gauge_panel.libsonnet... NOK - it's due to formatting issues i believe, please run jsonnetfmt -i bar_gauge_panel.libsonnet and try again

@Basti3n
Copy link
Author

Basti3n commented Sep 28, 2020

Does someone knows why my unit test keeps failing ?

Formatting ./grafonnet/bar_gauge_panel.libsonnet... NOK - it's due to formatting issues i believe, please run jsonnetfmt -i bar_gauge_panel.libsonnet and try again

Thanks for your answers,.
I ran what you said and there are still errors :/
The file should be correctly formated now.

If you have any clues, let me know ! :D

@insignias
Copy link

@Basti3n Do you get a returnCode when you run : jsonnetfmt --test -n 2 --max-blank-lines 2 --sort-imports --string-style s --comment-style s grafonnet/bar_gauge_panel.libsonnet; echo $?

@Basti3n
Copy link
Author

Basti3n commented Sep 29, 2020

@insignias It returns me "$" with nothing else.

@insignias
Copy link

It should give you a returnCode, may be you missed the '?' in the end: jsonnetfmt --test -n 2 --max-blank-lines 2 --sort-imports --string-style s --comment-style s bar_gauge_panel.libsonnet; echo $?
0
if it gives you a returnCode other 0 that means formatting still has errors and in order to fix it please run : jsonnetfmt -i -n 2 --max-blank-lines 2 --sort-imports --string-style s --comment-style s bar_gauge_panel.libsonnet and try again

@Basti3n
Copy link
Author

Basti3n commented Sep 29, 2020

I forgot the "?"
It gives me "2" as return code. But after running your last command it give me "0" now !

Let me correct my PR and see if everything is ok.

@fdw
Copy link

fdw commented Mar 25, 2021

Is there any way to get this merged?

@danxg87
Copy link

danxg87 commented Jun 4, 2021

Same question -- can this be merged soon? This is precisely what I was looking for re: bar gauge improvements! ❤️

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants