Chore: Move jsonitere outside of the internal package

[itsmylife]

What this PR does / why we need it:

With the current state we cannot use jsonitere package in grafana/grafana or in any project.
Please advise otherwise if you think the root is not a good place for that package.

[marefr]

In the root doesn't feel optimal. Since data/frame_json.go is the only one using it maybe data/util/jsonitere or data/jsonitere. Depending on how/where you want to use it, maybe backend/utils/jsonitere or backend/jsonitere (but this one feels a bit misplaced)

Nit. Personally I find it hard to read the package name jsonitere and as long it's been internal doesn't matter that much, but making it public now I think we should take the opportunity and change it if there's consensus.

[itsmylife]

We are gonna use it as a wrapper for "github.com/json-iterator/go" package. And then we use it everywhere we use github.com/json-iterator/go package. I agree that root is not an ideal place for this. I think backend/utils is much more appropriate.

Regarding the naming, do you have any suggestions? jsonwrapper maybe?

cc: @kylebrandt

[andresmgot]

The library suggest using jsoniter as the package name so we could use the same: https://pkg.go.dev/github.com/json-iterator/[email protected]#readme-usage

I would go with data/utils for the package but backend/utils works too.

Apart from that, I'd suggest to add some basic test coverage, any package exposed should have that.

[itsmylife]

I'll make the necessary changes. Testing makes sense.
@kylebrandt I need your input for this thread as well.

[kylebrandt]

I like backend utils, since this is for parsing json, it doesn't have to be used with the data layer (even though that is practically when we would use it generally).

[itsmylife]

@marefr @andresmgot I made the updates. Please check them. I am not sure what else I can test since this is just a wrapper.

[andresmgot]

I guess this is good enough to go, I have a couple of suggestions but not feeling strongly about those

[andresmgot]

sdkjsoniter ?

[itsmylife]

this makes sense. I'll do the change.

[andresmgot]

since you are mapping some of the things exported in the original package, maybe we should go over the rest of things that frame_json.go is using so it doesn't use directly github.com/json-iterator/go?

[itsmylife]

I tried that. But for this PR it'll make things much more complicated. Maybe I'll do it in a separate PR.