Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields: Regex - Combining metadata and fields #1029

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Jan 31, 2025

Create new combined fields variable which updates hidden fields and metadata variables.

Parent PR: #1028
Child PR: #1030

TODO:

  • Create scenes core issues:
    • By default the first group label is not visible, users need to scroll up to see it
image image

@gtk-grafana gtk-grafana self-assigned this Feb 4, 2025
@gtk-grafana gtk-grafana added the enhancement New feature or request label Feb 4, 2025
@gtk-grafana gtk-grafana added this to the 1.0.8 milestone Feb 4, 2025
@gtk-grafana gtk-grafana marked this pull request as ready for review February 4, 2025 14:03
@gtk-grafana gtk-grafana requested a review from a team as a code owner February 4, 2025 14:03
…ator-ui' into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui
…ator-ui' into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly! Unifying these filters is a fantastic change 👌

gtk-grafana and others added 2 commits February 5, 2025 06:46
* feat: convert levels variable to custom multi-select

---------

Co-authored-by: Matias Chomicki <[email protected]>
@gtk-grafana gtk-grafana merged commit d24720a into gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui Feb 5, 2025
3 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/1009/regex-fields-from-explore__operator-ui__variable-ui branch February 5, 2025 13:20
gtk-grafana added a commit that referenced this pull request Feb 5, 2025
* Fields: Regex - Supporting regex fields from Explore (#1023)
* Fields: Regex - Operator UI updates and double-quotes (#1028)
* Fields: Regex - Combining metadata and fields (#1029)
* Fields: Regex - custom multi-select levels variable  (#1030)

---------

Co-authored-by: Matias Chomicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants