Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(syntax/stdlib): add base64_decode helper function #953

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

hainenber
Copy link
Contributor

PR Description

This adds base64_decode helper function into Alloy's standard library.

Which issue(s) this PR fixes

Closes #948

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated

Sorry, something went wrong.

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@clayton-cornell clayton-cornell requested a review from a team May 30, 2024 19:39
@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 30, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
@clayton-cornell clayton-cornell requested a review from a team June 3, 2024 19:14
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs. Needs a code review from @grafana/grafana-alloy-maintainers

Copy link
Collaborator

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


```
> base64_decode("dGFuZ2VyaW5l")
tangerine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yum yum!

@clayton-cornell
Copy link
Contributor

@hainenber Looks like a quick conflict resolution for you and we can get this one merged :-)

@hainenber
Copy link
Contributor Author

Conflict resolved :D

@ptodev ptodev enabled auto-merge (squash) June 7, 2024 08:13
@ptodev ptodev merged commit fa02432 into grafana:main Jun 7, 2024
15 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add base64 decode function to stdlib
3 participants