remotecfg: set lower poll_frequency limit #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
tpaschalis
force-pushed
the
remotecfg-max-polling-rate
branch
from
086193d to
f14c5e8
Compare
erikbaranowski
approved these changes
May 30, 2024
| @@ -50,6 +50,8 @@ If not set, the self-reported `id` that {{< param "PRODUCT_NAME" >}} uses is a r | |||
| The `id` and `metadata` fields are used in the periodic request sent to the | |||
| remote endpoint so that the API can decide what configuration to serve. | |||
|
|
|||
| The `poll_frequency` must be set to least "1s". | |||
There was a problem hiding this comment.
Suggested change
| The `poll_frequency` must be set to least "1s". | |
| The `poll_frequency` must be set to at least `"1s"`. |
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds a lower limit for the poll_frequency used in the remotecfg block so that Alloy instances don't accidentally hammer a server implementation. I think that's a good starting point but this value can be fine-tuned in the future.
Which issue(s) this PR fixes
No issue filed.
Notes to the Reviewer
PR Checklist