Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Agent Static to Alloy migration #930

Merged
merged 1 commit into from
May 27, 2024
Merged

Update Agent Static to Alloy migration #930

merged 1 commit into from
May 27, 2024

Conversation

clayton-cornell
Copy link
Contributor

PR Description

Update Agent Static to Alloy migration - add Alloy installed prerequisite.

Remove bullet about being familiar with Components. Static migration is the only place it was mentioned like this and it seems unnecessary.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell clayton-cornell added type/docs Docs Squad label across all Grafana Labs repos backport release/v1.0 backport release/v1.1 labels May 27, 2024
@clayton-cornell clayton-cornell requested a review from a team May 27, 2024 18:07
rfratto
rfratto approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I can't remember if that line was there on purpose but it doesn't seem to be relevant for a migration.

@clayton-cornell clayton-cornell merged commit 6ef896d into main May 27, 2024
21 checks passed
@clayton-cornell clayton-cornell deleted the docs/update-static-migration branch May 27, 2024 20:30
github-actions bot pushed a commit that referenced this pull request May 27, 2024
@clayton-cornell @grafanabot
Removed ref to components, added Alloy install prereq (#930)
0c3f57c 
(cherry picked from commit 6ef896d)
@github-actions github-actions bot mentioned this pull request May 27, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 27, 2024
@clayton-cornell @grafanabot
Removed ref to components, added Alloy install prereq (#930)
b315ec3 
(cherry picked from commit 6ef896d)
@github-actions github-actions bot mentioned this pull request May 27, 2024
Merged
clayton-cornell added a commit that referenced this pull request May 27, 2024
@github-actions @clayton-cornell
Removed ref to components, added Alloy install prereq (#930) (#933)
00e044f 
(cherry picked from commit 6ef896d)

Co-authored-by: Clayton Cornell <[email protected]>
clayton-cornell added a commit that referenced this pull request May 27, 2024
@github-actions @clayton-cornell
Removed ref to components, added Alloy install prereq (#930) (#932)
28d7321 
(cherry picked from commit 6ef896d)

Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
backport release/v1.0 backport release/v1.1 frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clayton-cornell @rfratto