-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates OTEL version to v0.101.0. #906
Conversation
4b21196
to
ef5d783
Compare
Hi, thanks for your contribution! We update our Otel dependency before every Alloy release in one go to make sure that we reflect all otel changes in our components. If you don't mind, could we merge your branch to the update-otel-v0.101.0 instead of main? I would then use your changes as a start to update the rest of the otel components |
@wildum No problem. I wasn't sure if this was the case as I noticed with the recent release OTEL was still at Also, hopefully there isn't too much else to do. I tried to look at the release notes for v0.100.0 and v0.101.0 and see what components in Alloy had updates. I "think" I hit what needed to be done in this PR? I could be wrong though... |
Hey you are right actually, sorry I usually expect many more changes when we upgrade our otel dependency but I just went through the release notes and it looks like you did all the changes! That's really super helpful, I will review your code and then we will merge it to main directly |
docs/sources/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol.processor.probabilistic_sampler.md
Outdated
Show resolved
Hide resolved
Updates vcenterreceiver and its many bug fixes and updates for use by Alloy. Updates probabilisticsampleprocessor to use new failed_closed config.
Co-authored-by: Clayton Cornell <[email protected]>
7bebce3
to
11853c3
Compare
internal/converter/internal/otelcolconvert/testdata/probabilistic_sampler.alloy
Outdated
Show resolved
Hide resolved
Seems like changing the default value to true is making some tests fail. I can take a look at it on Monday |
…d sample conditions
@wildum digging into it a bit more, the new config field refuses data when randomness cannot be determined from the log/trace (which was the case in these test conditions). I fixed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the tests :) When you have time, can you update the changelog and rebase with main? I will then merge the branch
Merged, thanks again @StefanKurek ! |
PR Description
Updates vcenterreceiver and its many bug fixes and updates for use by Alloy. Updates probabilisticsampleprocessor to use new failed_closed config.
Which issue(s) this PR fixes
N/A
Notes to the Reviewer
PR Checklist