Update pyroscope/ebpf to v0.4.6 #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
added
the
backport-to-agent
korniltsev
approved these changes
Apr 25, 2024
Note: Pyroscope updated its prometheus/common dependecy and hence this required further updates.
This also modifieds the way we do defaulting and valides those two new fields.
This updates the pyroscope/ebpf annotations to both have alloy and river ones.
simonswine
force-pushed
the
20240425_update-pyroscope/ebpf-v0.4.4
branch
from
7832e34 to
e7be4b1
Compare
simonswine
changed the title
This also includes a test to make sure debug data is marshalled correctly.
simonswine
changed the title
|
@korniltsev I think it is worth giving this another try. |
korniltsev
approved these changes
Apr 27, 2024
hainenber
pushed a commit
to hainenber/alloy
that referenced
this pull request
May 1, 2024
* Update pyroscope/ebpf to v0.4.4 Note: Pyroscope updated its prometheus/common dependecy and hence this required further updates. * Also update windows exporter * Allow pid maps to be configured This also modifieds the way we do defaulting and valides those two new fields. * Update pyroscope/ebpf v0.4.5 This updates the pyroscope/ebpf annotations to both have alloy and river ones. * Add some testing for argument validation * Update to v0.4.6 to fix debug data This also includes a test to make sure debug data is marshalled correctly.
polyrain
pushed a commit
to polyrain/alloy
that referenced
this pull request
May 1, 2024
* Update pyroscope/ebpf to v0.4.4 Note: Pyroscope updated its prometheus/common dependecy and hence this required further updates. * Also update windows exporter * Allow pid maps to be configured This also modifieds the way we do defaulting and valides those two new fields. * Update pyroscope/ebpf v0.4.5 This updates the pyroscope/ebpf annotations to both have alloy and river ones. * Add some testing for argument validation * Update to v0.4.6 to fix debug data This also includes a test to make sure debug data is marshalled correctly.
simonswine
added
the
backport-to-agent:done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Pyroscope updated its prometheus/common dependency and hence this required further updates.
cc @korniltsev @andriikushch
The new version v0.4.4 allows to configure the size of the PIDsmap, which has become a limitation for some deployments. (see grafana/pyroscope#3181)
As part of the PR I also released v0.4.6, which updates the annotations to be "alloy" compatible, so the debug info is displayed as before.