Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Beyla 2.0 #2747

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Add support for Beyla 2.0 #2747

merged 12 commits into from
Feb 19, 2025
+532 −58

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Feb 18, 2025 •
edited
Loading

PR Description

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@marctc marctc requested review from a team as code owners February 18, 2025 13:42
dehaansa
dehaansa reviewed Feb 18, 2025
View reviewed changes
thampiotr
thampiotr approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - there are a lot of new config options that we'll need to keep backwards-compatibility for. I think the names are reasonable, but I'd encourage you to review them again in case you want to make any changes. Beyla is still in public preview, but I reckon we still don't want to make unnecessary breaking changes.

grcevski
grcevski approved these changes Feb 19, 2025
View reviewed changes
Copy link

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited
Loading

💻 Deploy preview deleted.

@marctc marctc requested a review from dehaansa February 19, 2025 15:39
@marctc marctc merged commit ccaacca into main Feb 19, 2025
32 checks passed
@marctc marctc deleted the beyla_2.0 branch February 19, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehaansa dehaansa dehaansa approved these changes

@grcevski grcevski grcevski approved these changes

@thampiotr thampiotr thampiotr approved these changes

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Got "panic: can't fork 0 joiners" if not in debug mode
4 participants
@marctc @dehaansa @grcevski @thampiotr