Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livedebugging to otel connectors #2598

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Feb 3, 2025

PR Description

Which issue(s) this PR fixes

Fixes #2254

Notes to the Reviewer

I manually tested the generic connector implementation with the spanmetrics connector + tested additionally the spanlogs connector.

The implementation follows the same pattern as the other ones (processors, receivers...)

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • [na] Tests updated
  • [na] Config converters updated

@wildum wildum requested review from clayton-cornell and a team as code owners February 3, 2025 10:21
Copy link
Contributor

github-actions bot commented Feb 3, 2025

💻 Deploy preview deleted.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 3, 2025
@clayton-cornell
Copy link
Contributor

No need for docs review if it's just adding the component to the list of supported components.

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wildum wildum merged commit 9324ba5 into main Feb 5, 2025
33 checks passed
@wildum wildum deleted the live-debugging-otel-connectors branch February 5, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add live debugging support to otel connectors
3 participants