Actually use tls alloy and not yaml. #2461
Merged
+32
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
dehaansa
approved these changes
Jan 21, 2025
mattdurham
added a commit
that referenced
this pull request
Jan 21, 2025
* Actually use tls alloy and not yaml. * remove bad test (cherry picked from commit 419e997)
mattdurham
added a commit
that referenced
this pull request
Jan 21, 2025
* update changelog for rc (#2360) * update changelog for rc * update changelog for rc Signed-off-by: matt durham <[email protected]> * fix conversion * Fanout: reduce allocation related to staleness tracking (#2405) (cherry picked from commit c58c114) * Actually use tls alloy and not yaml. (#2461) * Actually use tls alloy and not yaml. * remove bad test (cherry picked from commit 419e997) * Cherry pick staleness and tls. --------- Signed-off-by: matt durham <[email protected]> Co-authored-by: Piotr <[email protected]>
clayton-cornell
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Bug in RC that it was using the yaml tls config and not the alloy version. Added tests for the parsering since using direct structs works fine.
Notes to the Reviewer
PR Checklist