database_observability: log schema name in query samples #2444
+78
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewnolf
reviewed
Jan 20, 2025
| continue | ||
| } | ||
| } | ||
|
|
||
| stmt, err := sqlparser.Parse(sampleText) | ||
| if err != nil { | ||
| level.Error(c.logger).Log("msg", "failed to parse sql query", "digest", digest, "err", err) | ||
| level.Error(c.logger).Log("msg", "failed to parse sql query", "digest", digest, "schema", schemaName, "err", err) |
There was a problem hiding this comment.
Shall we use schemaName before digest. For consistency with other messages, and also to go from broad -> specific to help with log searching
matthewnolf
approved these changes
Jan 20, 2025
Capture and log schema name in query samples fetched from mysql.
cristiangreco
force-pushed
the
cristian/dbo11y-query-sample-schema
branch
from
7727a1b to
ae58553
Compare
clayton-cornell
pushed a commit
that referenced
this pull request
Jan 21, 2025
database_observability: log schema name in query samples Capture and log schema name in query samples fetched from mysql.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Capture and log schema name in query samples fetched from mysql.
Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist