Disable debug metrics for components inside foreach, and for foreach itself. #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
reviewed
Jan 15, 2025
wildum
approved these changes
Jan 15, 2025
ptodev
force-pushed
the
ptodev/dynamic-pipelines-disable-metrics
branch
from
5578777 to
6a2db08
Compare
ptodev
added a commit
that referenced
this pull request
Jan 27, 2025
wildum
added a commit
that referenced
this pull request
Feb 12, 2025
* Proposal for dynamic pipelines * Foreach prototype * Initial implementation * wip * Fixes to summation1 and summation2 * summation1 only sends during run() * summation2 tracks the sum via metrics instead of an export * fix foreach run * foreach uses the value from the collection via the var * compute an ID for the foreach instances and add tests * rework foreach txtar tests * support using modules inside of foreach * cleanup * update frontend to use the moduleID of the component instead of the module one * plug the foreach node to the UI * fix internal template components link * update comment in component references * cleanups * Disable debug metrics for components inside foreach, and for foreach itself. (#2404) * Add stability lvl to config blocks (#2441) * add stability lvl to config blocks * fix import git test * Add tests for types other than integers (#2436) * Add tests for types other than integers * Minor fixes to string_receiver * Add a foreach test for maps which contain maps * Add docs for foreach (#2447) * Add docs for foreach * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> * Add a shared experimental_feature snippet * Addressing PR feedback * Apply suggestions from code review Co-authored-by: William Dumont <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: William Dumont <[email protected]> * use full hash on foreach instances and fix test * Add a changelog entry. * typo * allow non alphanum strings * add test for wrong collection type * added capsule test * Add more tests for non-alphanumeric strings. * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> * Apply suggestions from code review Co-authored-by: Clayton Cornell <[email protected]> * Add comments regarding the override registry for modules * Rename hashObject to objectFingerprint * add comment for the hash function * add additional detail to the comment --------- Co-authored-by: William Dumont <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a separate PR for @wildum to review the changes before they go on the main dynamic pipelines branch.