Update to Prometheus v2.54.1 #1574
Open
+408
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ptodev
force-pushed
the
ptodev/upgrade-prometheus
branch
2 times, most recently
from
61de1dc to
5549f2a
Compare
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
ptodev
force-pushed
the
ptodev/upgrade-prometheus
branch
from
5549f2a to
be17248
Compare
|
💻 Deploy preview available: https://deploy-preview-alloy-1574-zb444pucvq-vp.a.run.app/docs/alloy/latest/ |
ptodev
force-pushed
the
ptodev/upgrade-prometheus
branch
2 times, most recently
from
933b511 to
2558a85
Compare
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/discovery/discovery.linode.md
Outdated
Show resolved
Hide resolved
ptodev
force-pushed
the
ptodev/upgrade-prometheus
branch
4 times, most recently
from
551a3f6 to
5e9daee
Compare
ptodev
force-pushed
the
ptodev/upgrade-prometheus
branch
from
5e9daee to
2818d1e
Compare
Co-authored-by: Clayton Cornell <[email protected]>
ptodev
commented
Feb 6, 2025
| @@ -69,6 +69,8 @@ type Arguments struct { | |||
| Params url.Values `alloy:"params,attr,optional"` | |||
| // Whether to scrape a classic histogram that is also exposed as a native histogram. | |||
| ScrapeClassicHistograms bool `alloy:"scrape_classic_histograms,attr,optional"` | |||
| // Whether to scrape native histograms. | |||
| ScrapeNativeHistograms bool `alloy:"scrape_native_histograms,attr,optional"` | |||
There was a problem hiding this comment.
Related to this Prometheus change: prometheus/prometheus#13987
We don't have to have the new scrape_native_histograms argument in order to maintain backwards compatibility with older Alloy versions. However, the Prometheus docs mention that much of this functionality is experimental, so I thought it'd be good to be able to disable it.
By default scrape_native_histograms is set to true to maintain backwards compatibility.
mattdurham
reviewed
Feb 7, 2025
| Duration: s.metrics.requestDuration, | ||
| RequestBodySize: s.metrics.rxMessageSize, | ||
| ResponseBodySize: s.metrics.txMessageSize, | ||
| InflightRequests: s.metrics.inflightRequests, | ||
| } | ||
|
|
||
| ri := middleware.RouteInjector{ |
There was a problem hiding this comment.
What is this? Is this part of the upgrade?
mattdurham
reviewed
Feb 7, 2025
| @@ -242,6 +243,9 @@ func convertConfigs(cfg Arguments) (*config.Config, error) { | |||
| SendExemplars: rw.SendExemplars, | |||
| SendNativeHistograms: rw.SendNativeHistograms, | |||
|
|
|||
| //TODO: Make this configurable? | |||
| ProtobufMessage: config.RemoteWriteProtoMsgV1, | |||
There was a problem hiding this comment.
This feels like we would need this when we upgrade to prom 3.0, so maybe add that to the todo?
mattdurham
reviewed
Feb 7, 2025
| } | ||
|
|
||
| var err error | ||
| _, err = uuid.Parse(a.OAuth.ClientID) |
There was a problem hiding this comment.
Is this specific to Azure? Not sure in generic oauth this is true.
mattdurham
approved these changes
Feb 7, 2025
clayton-cornell
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Upgrading to the latest Prometheus version - v0.54.1.
I didn't add bugfixes to the changelog, because I'm not too sure which ones exactly affect Alloy.
PR Checklist