Add support for minReadySeconds in helm chart

grafana · Jan 28, 2025 · 36b2ec9 · 36b2ec9
1 parent e621c94
commit 36b2ec9
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 3 deletions.
diff --git a/operations/helm/charts/alloy/CHANGELOG.md b/operations/helm/charts/alloy/CHANGELOG.md
@@ -7,6 +7,13 @@ This document contains a historical list of changes between releases. Only
 changes that impact end-user behavior are listed; changes to documentation or
 internal API changes are not present.
 
+X.X.X
+----------
+
+### Enhancements
+
+- Add support for configuring minReadySeconds in Helm chart. (@PabloPie)
+
 0.11.0 (2025-01-23)
 ----------
 

diff --git a/operations/helm/charts/alloy/README.md b/operations/helm/charts/alloy/README.md
@@ -87,6 +87,7 @@ useful if just using the default DaemonSet isn't sufficient.
 | controller.initContainers | list | `[]` |  |
 | controller.nodeSelector | object | `{}` | nodeSelector to apply to Grafana Alloy pods. |
 | controller.parallelRollout | bool | `true` | Whether to deploy pods in parallel. Only used when controller.type is 'statefulset'. |
+| controller.minReadySeconds | int | `10` | How many additional seconds to wait before considering a pod ready. |
 | controller.podAnnotations | object | `{}` | Extra pod annotations to add. |
 | controller.podDisruptionBudget | object | `{"enabled":false,"maxUnavailable":null,"minAvailable":null}` | PodDisruptionBudget configuration. |
 | controller.podDisruptionBudget.enabled | bool | `false` | Whether to create a PodDisruptionBudget for the controller. |

diff --git a/operations/helm/charts/alloy/templates/controllers/daemonset.yaml b/operations/helm/charts/alloy/templates/controllers/daemonset.yaml
@@ -11,7 +11,7 @@ metadata:
   {{- end }}
 spec:
   {{- if ge (int .Capabilities.KubeVersion.Minor) 22 }}
-  minReadySeconds: 10
+  minReadySeconds: {{ .Values.controller.minReadySeconds }}
   {{- end }}
   selector:
     matchLabels:

diff --git a/operations/helm/charts/alloy/templates/controllers/deployment.yaml b/operations/helm/charts/alloy/templates/controllers/deployment.yaml
@@ -14,7 +14,7 @@ spec:
   replicas: {{ .Values.controller.replicas }}
   {{- end }}
   {{- if ge (int .Capabilities.KubeVersion.Minor) 22 }}
-  minReadySeconds: 10
+  minReadySeconds: {{ .Values.controller.minReadySeconds }}
   {{- end }}
   selector:
     matchLabels:

diff --git a/operations/helm/charts/alloy/templates/controllers/statefulset.yaml b/operations/helm/charts/alloy/templates/controllers/statefulset.yaml
@@ -20,7 +20,7 @@ spec:
   podManagementPolicy: Parallel
   {{- end }}
   {{- if ge (int .Capabilities.KubeVersion.Minor) 22 }}
-  minReadySeconds: 10
+  minReadySeconds: {{ .Values.controller.minReadySeconds }}
   {{- end }}
   serviceName: {{ include "alloy.fullname" . }}
   selector:

diff --git a/operations/helm/charts/alloy/values.yaml b/operations/helm/charts/alloy/values.yaml
@@ -188,6 +188,9 @@ controller:
   # 'statefulset'.
   parallelRollout: true
 
+  # -- How many additional seconds to wait before considering a pod ready.
+  minReadySeconds: 10
+
   # -- Configures Pods to use the host network. When set to true, the ports that will be used must be specified.
   hostNetwork: false