[FIX] the hostname of enpoint parser should parse dash symbol.

[gradyzhuo]

Summary by CodeRabbit

• 新特性
  • 更新了主机名解析的正则表达式，允许更多字符出现在主机名末尾。
  • 增加了一个新的测试方法，以验证包含破折号的主机的连接字符串解析。

[coderabbitai]

概述

遍历

此更改修改了 EndpointParser 中的主机名正则表达式模式，扩展了可接受的字符范围。新模式允许在主机名末尾使用更多字符（.、-、_），增加了主机名解析的灵活性。同时，添加了一个新的测试用例，验证包含短横线的主机名是否能正确解析。

变更

文件	变更摘要
Sources/EventStoreDB/ClientSettings/Parser/EndpointParser.swift	更新 hostRegex 正则表达式模式
Tests/EventStoreDBTests/ConnectionStringParserTests.swift	添加 test_host_should_be_parsed_host_contains_dash_succeed() 测试方法

诗歌

🐰 正则魔法，悄然变幻
主机名之舞，更显优雅
短横线轻舞，下划线飞扬
解析之路，宽广又明朗
代码如诗，兔子微笑 🌈

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Sources/EventStoreDB/ClientSettings/Parser/EndpointParser.swift (1)

90-90: 建议增加额外的主机名验证

考虑添加以下验证：

1. 主机名总长度不应超过253个字符
2. 每个标签（点号之间的部分）不应超过63个字符
3. 主机名不应以破折号开头或结尾

建议修改正则表达式如下：

- One(.anyOf(".-_"))
+ TryCapture {
+     Regex {
+         ZeroOrMore(.word.subtracting(.anyOf("-")))
+         One(.anyOf(".-_"))
+         ZeroOrMore(.word)
+     }
+ } transform: { 
+     let hostname = String($0)
+     guard hostname.count <= 253,
+           !hostname.hasPrefix("-"),
+           !hostname.hasSuffix("-"),
+           hostname.split(separator: ".").allSatisfy({ $0.count <= 63 })
+     else { return nil }
+     return hostname
+ }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1b83af and 7ac01d9.

📒 Files selected for processing (2)

• Sources/EventStoreDB/ClientSettings/Parser/EndpointParser.swift (1 hunks)
• Tests/EventStoreDBTests/ConnectionStringParserTests.swift (1 hunks)

🔇 Additional comments (2)

Tests/EventStoreDBTests/ConnectionStringParserTests.swift (1)

48-56: 测试用例设计合理！

新增的测试用例很好地验证了包含破折号的主机名解析功能，与现有的测试用例（localhost和IP地址）形成了完整的测试覆盖。

Sources/EventStoreDB/ClientSettings/Parser/EndpointParser.swift (1)

90-90: 正则表达式修改恰当！

通过添加破折号和下划线的支持，使主机名解析更符合实际使用场景。

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.24%. Comparing base (f1b83af) to head (7ac01d9).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   13.20%   13.24%   +0.04%     
==========================================
  Files         110      110              
  Lines       19050    19059       +9     
==========================================
+ Hits         2516     2525       +9     
  Misses      16534    16534              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.