Improve dependency graph failure handling #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: failing-build-with-comment-on-failure
|
Job Summary for gradle-build-actionDemo adding Build Scan® comment to PR :: successful-build-with-always-comment
|
- Translate to env var for init-script support - Use when deciding whether to log or rethrow errors - Add a custom error type to trigger failure in post action
- Update test to use input param - Rename Job to indicate expected failure
bigdaz
force-pushed
the
dd/dependency-graph-failure-handling
branch
from
eabd1be to
610728f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One goal for the original dependency-graph support was to minimize it's impact on existing workflows, by operating transparently and not impacting the build outcome. This meant that any failures in dependency-graph generation or submission were logged as warnings, but did not cause the workflow to fail.
However, in some cases the primary purpose of a workflow is to generate and submit a dependency graph: in these cases it is desirable to have the workflow fail when this process breaks.
This PR introduces a new
dependency-graph-continue-on-failureparameter, which whenfalsewill enable the latter behaviour. It also adds test coverage for different failures in dependency graph generation and submission.Fixes #1034
Fixes #997