Skip to content

Commit

Permalink
Remove 'gradle-executable' input param
Browse files Browse the repository at this point in the history
  • Loading branch information
bigdaz committed Jan 4, 2024
1 parent 345641a commit a36d6f8
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 21 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/integ-test-execution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,6 @@ jobs:
gradle-version: release-candidate
build-root-directory: .github/workflow-samples/no-wrapper
arguments: help
- name: Test use defined Gradle executable
uses: ./
with:
gradle-executable: .github/workflow-samples/groovy-dsl/gradlew${{ matrix.script-suffix }}
build-root-directory: .github/workflow-samples/no-wrapper
arguments: help

gradle-versions:
strategy:
Expand Down
5 changes: 0 additions & 5 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,6 @@ inputs:
required: false
deprecation-message: Using the action to execute Gradle directly is deprecated in favor of using the action to setup Gradle, and executing Gradle in a subsequent Step. See https://github.com/gradle/gradle-build-action?tab=readme-ov-file#use-the-action-to-setup-gradle.

gradle-executable:
description: Path to the Gradle executable. If specified, this executable will be added to the PATH and used for invoking Gradle.
required: false
deprecation-message: Using the action to execute Gradle directly is deprecated in favor of using the action to setup Gradle, and executing Gradle in a subsequent Step. See https://github.com/gradle/gradle-build-action?tab=readme-ov-file#use-the-action-to-setup-gradle.

generate-job-summary:
description: When 'false', no Job Summary will be generated for the Job.
required: false
Expand Down
2 changes: 1 addition & 1 deletion src/gradlew.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function validateGradleWrapper(buildRootDirectory: string): void {
function verifyExists(file: string, description: string): void {
if (!fs.existsSync(file)) {
throw new Error(
`Cannot locate ${description} at '${file}'. Specify 'gradle-version' or 'gradle-executable' for projects without Gradle wrapper configured.`
`Cannot locate ${description} at '${file}'. Specify 'gradle-version' for projects without Gradle wrapper configured.`
)
}
}
Expand Down
4 changes: 0 additions & 4 deletions src/input-params.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ export function getGradleVersion(): string {
return core.getInput('gradle-version')
}

export function getGradleExecutable(): string {
return core.getInput('gradle-executable')
}

export function getArguments(): string[] {
const input = core.getInput('arguments')
return parseArgsStringToArgv(input)
Expand Down
5 changes: 0 additions & 5 deletions src/provision.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ export async function provisionGradle(): Promise<string | undefined> {
return addToPath(await installGradle(gradleVersion))
}

const gradleExecutable = params.getGradleExecutable()
if (gradleExecutable !== '') {
return addToPath(gradleExecutable)
}

return undefined
}

Expand Down

0 comments on commit a36d6f8

Please sign in to comment.