Skip to content

Commit

Permalink
Remove node warnings from workflows
Browse files Browse the repository at this point in the history
- Use setup-node to control Node version used to build
- Use Node20 compatible actions in custom actions
  • Loading branch information
bigdaz committed Jan 24, 2024
1 parent f1361c7 commit 75b3db1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
8 changes: 6 additions & 2 deletions .github/actions/build-dist/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@ name: 'Build and upload distribution'
runs:
using: "composite"
steps:
- uses: actions/setup-node@v4
with:
node-version: 20
- name: Build distribution
shell: bash
run: |
npm -v
node -v
npm install
npm run build
- name: Upload distribution
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
path: dist/

2 changes: 1 addition & 1 deletion .github/actions/download-dist/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ runs:
steps:
- name: Download dist
if: ${{ env.DOWNLOAD_DIST == 'true' }}
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dist
path: dist/
3 changes: 3 additions & 0 deletions .github/workflows/ci-verify-outputs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ jobs:
steps:
- name: Checkout sources
uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
- name: Build
run: |
npm -v
Expand Down

0 comments on commit 75b3db1

Please sign in to comment.