Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to exposures for excluding all unverified collection items #243

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Add flag to exposures for excluding all unverified collection items #243

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6900df8
add flag to exclude unverified collection items
alex-float-on Mar 13, 2024
31a7f6a
simplify check for moderation status
alex-float-on Mar 14, 2024
03c5130
leave dashboards alone
alex-float-on Mar 14, 2024
4c09d82
Merge branch 'master' into exclude-unverified
gouline Mar 14, 2024
0ca9890
Merge branch 'master' into exclude-unverified
gouline Mar 14, 2024
964ad98
Add
alex-float-on Mar 15, 2024
da0ea82
Revise ordering of exclusion logic
alex-float-on Mar 15, 2024
894b497
revert flag name now that we have alignment
alex-float-on Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dbtmetabase/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,12 +359,20 @@ def models(
is_flag=True,
help="Include personal Metabase collections.",
)
@click.option(
"--exclude-unverified-cards",
envvar="EXCLUDE_UNVERIFIED_CARDS",
show_envvar=True,
is_flag=True,
help="Exclude cards that have not been verified.",
)
def exposures(
output_path: str,
output_grouping: Optional[str],
include_collections: Optional[Sequence[str]],
exclude_collections: Optional[Sequence[str]],
allow_personal_collections: bool,
exclude_unverified_cards: bool,
core: DbtMetabase,
):
core.extract_exposures(
Expand All @@ -375,6 +383,7 @@ def exposures(
exclude=exclude_collections,
),
allow_personal_collections=allow_personal_collections,
exclude_unverified_cards=exclude_unverified_cards,
)


Expand Down
9 changes: 9 additions & 0 deletions dbtmetabase/_exposures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def extract_exposures(
output_grouping: Optional[str] = None,
collection_filter: Optional[Filter] = None,
allow_personal_collections: bool = False,
exclude_unverified_cards: bool = False,
) -> Iterable[Mapping]:
"""Extract dbt exposures from Metabase.

Expand All @@ -54,6 +55,7 @@ def extract_exposures(
output_grouping (Optional[str], optional): Grouping for output YAML files, supported values: "collection" (by collection slug) or "type" (by entity type). Defaults to None.
collection_filter (Optional[Filter], optional): Filter Metabase collections. Defaults to None.
allow_personal_collections (bool, optional): Allow personal Metabase collections. Defaults to False.
exclude_unverified_cards (bool, optional): Exclude unverified cards. Defaults to False.

Returns:
Iterable[Mapping]: List of parsed exposures.
Expand Down Expand Up @@ -89,6 +91,13 @@ def extract_exposures(
uid=collection["id"],
models=("card", "dashboard"),
):
if (
exclude_unverified_cards
and item.get("moderated_status") != "verified"
and item.get("model") == "card"
):
_logger.debug("Skipping unverified card '%s'", item["name"])
continue
depends = set()
native_query = ""
header = ""
Expand Down
Loading