simplify check for moderation status

gouline · Mar 14, 2024 · 31a7f6a · 31a7f6a
1 parent 6900df8
commit 31a7f6a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/dbtmetabase/_exposures.py b/dbtmetabase/_exposures.py
@@ -90,8 +90,10 @@ def extract_exposures(
             for item in self.metabase.get_collection_items(
                 uid=collection["id"],
                 models=("card", "dashboard"),
-                exclude_unverified=exclude_unverified,
             ):
+                if exclude_unverified and item.get("moderated_status") != "verified":
+                    _logger.debug("Skipping unverified item '%s'", item["id"])
+                    continue
                 depends = set()
                 native_query = ""
                 header = ""

diff --git a/dbtmetabase/metabase.py b/dbtmetabase/metabase.py
@@ -131,7 +131,6 @@ def get_collection_items(
         self,
         uid: str,
         models: Sequence[str],
-        exclude_unverified: bool = False,
     ) -> Sequence[Mapping]:
         """Retrieves collection items of specific types (e.g. card, dashboard, collection)."""
         results = list(
@@ -141,16 +140,6 @@ def get_collection_items(
                 params={"models": models},
             )
         )
-        if exclude_unverified:
-            verified_results = list(
-                self._api(
-                    method="get",
-                    path=f"/api/search/",
-                    params={"models": models, "verified": True},
-                )
-            )
-            verified_ids = [y['id'] for y in verified_results]
-            results = [x for x in results if x['id'] in verified_ids]
         results = list(filter(lambda x: x["model"] in models, results))
         return results