feat: convert customTagRender to component

goto · Jan 23, 2025 · 453e023 · 453e023
1 parent f960306
commit 453e023
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/lerna.json b/lerna.json
@@ -2,7 +2,7 @@
     "packages": ["packages/*"],
     "npmClient": "yarn",
     "useWorkspaces": true,
-    "version": "0.11.5-alpha.0",
+    "version": "0.11.5-alpha.1",
     "command": {
         "version": {
             "message": "chore(release): publish %s"

diff --git a/packages/apsara-icons/package.json b/packages/apsara-icons/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@goto-company/icons",
-    "version": "0.11.5-alpha.0",
+    "version": "0.11.5-alpha.1",
     "description": "Apsara icons",
     "scripts": {
         "build": "node scripts/build.js",

diff --git a/packages/apsara-ui/package.json b/packages/apsara-ui/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@goto-company/apsara",
-    "version": "0.11.5-alpha.0",
+    "version": "0.11.5-alpha.1",
     "description": "A list of base components for apsara",
     "author": "Praveen Yadav <[email protected]>",
     "license": "Apache-2.0",

diff --git a/packages/apsara-ui/src/Combobox/Combobox.stories.tsx b/packages/apsara-ui/src/Combobox/Combobox.stories.tsx
@@ -1,7 +1,7 @@
 import React, { useState } from "react";
 import { SelectProps } from "rc-select";
 
-import Combobox, { customTagRender } from "./Combobox";
+import Combobox, { CustomTagRender } from "./Combobox";
 
 export default {
     title: "General/Combobox",
@@ -25,7 +25,14 @@ const options: SelectOptionType = [
 ];
 
 const Template = (args: SelectProps) => (
-    <Combobox tagRender={(props) => customTagRender({ ...props, className: "testing" })} {...args} />
+    <Combobox
+        tagRender={(props) => (
+            <div>
+                <CustomTagRender {...props} isError className="testing" />{" "}
+            </div>
+        )}
+        {...args}
+    />
 );
 
 export const MultiSelectWithSearch = Template.bind({});

diff --git a/packages/apsara-ui/src/Combobox/Combobox.tsx b/packages/apsara-ui/src/Combobox/Combobox.tsx
@@ -26,7 +26,7 @@ type CustomTagRenderProps = CustomTagProps &
         isError?: boolean;
     };
 
-export const customTagRender = (props: CustomTagRenderProps) => {
+export const CustomTagRender = (props: CustomTagRenderProps) => {
     const { label, closable, onClose, isError, className = "", ...restProps } = props;
 
     return (