feat: Add a function to get updated spec (onAltGoslingSpecUpdate)
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehilyi
commented
Feb 20, 2025
Comment on lines
-27
to
+38
| const examples = {'Bar chart': barChart, | ||
| 'Heatmap': heatmap, | ||
| 'Matrix': matrix, | ||
| 'Comparison of four samples': doubleMarks, | ||
| 'Annotated chart': ruleMark, | ||
| 'Comparing two samples': compareTwoSamples, | ||
| 'Linked views': brush, | ||
| 'Circular halves': circularHalves, | ||
| 'Gene annotations': geneAnnotation, | ||
| 'Ideogram expression': ideogramWithArea, | ||
| }; | ||
| const examples = { | ||
| 'Bar chart': barChart, | ||
| 'Heatmap': heatmap, | ||
| 'Matrix': matrix, | ||
| 'Comparison of four samples': doubleMarks, | ||
| 'Annotated chart': ruleMark, | ||
| 'Comparing two samples': compareTwoSamples, | ||
| 'Linked views': brush, | ||
| 'Circular halves': circularHalves, | ||
| 'Gene annotations': geneAnnotation, | ||
| 'Ideogram expression': ideogramWithArea, | ||
| }; |
There was a problem hiding this comment.
I probably had to turn off my auto-linting. All formatting changes reflect the .eslintrc.cjs option defined in this project.
sehilyi
commented
Feb 20, 2025
Comment on lines
-89
to
+102
| { selectedExample === 'editor' ? | ||
| (editorValid === 'invalid' ? | ||
| <Typography variant='body1' color='error'>No Gosling or AltGosling components could be loaded.</Typography> | ||
| : <AltGoslingComponent spec={editorText} download name={selectedExample} /> | ||
| ) | ||
| : <AltGoslingComponent spec={examples[selectedExample]} download name={selectedExample} /> | ||
| } | ||
| {(() => { | ||
| let goslingSpec: string; | ||
| if (selectedExample === 'editor' && editorValid === 'invalid') { | ||
| return <Typography variant='body1' color='error'>No Gosling or AltGosling components could be loaded.</Typography>; | ||
| } else if (selectedExample === 'editor' && editorValid !== 'invalid') { | ||
| goslingSpec = editorText; | ||
| } else { | ||
| goslingSpec = examples[selectedExample]; | ||
| } | ||
| return <AltGoslingComponent spec={goslingSpec} download name={selectedExample} onAltGoslingSpecUpdate={spec => { | ||
| console.log('AltGosling Spec Updated', spec); | ||
| }} />; | ||
| })()} |
There was a problem hiding this comment.
This is the only part I edited to include onAltGoslingSpecUpdate.
There was a problem hiding this comment.
Changed the structure a bit to make it more readable and to avoid duplicated <AltGoslingComponent/> use
sehilyi
commented
Feb 20, 2025
| // Update current alt | ||
| updateAltPanelDisplay(altSpec); | ||
| // Reset data panels | ||
| setDataPanelCurrent(undefined); | ||
| setDataPanelPrevious(undefined); | ||
| // setExpandedAltPanelWrapper(['tree']); | ||
| // setExpandedDataPanelWrapper(['tree']); | ||
|
|
||
| // Callback function to pass over the AltGoslingSpec | ||
| props.onAltGoslingSpecUpdate?.(altSpec); |
There was a problem hiding this comment.
A place to call the onAltGoslingSpecUpdate
There was a problem hiding this comment.
Do we want to add this to the AltGoslingCompProps?
There was a problem hiding this comment.
(This would allow a user to change change behaviour as well)
There was a problem hiding this comment.
Yes, I already added it as well
thomcsmits
reviewed
Feb 20, 2025
| @@ -38,17 +38,18 @@ interface AltGoslingCompProps extends GoslingCompProps { | |||
| layoutPanels?: 'vertical' | 'horizontal'; | |||
| download?: boolean; | |||
| dataTableRoundValues?: boolean; | |||
| onAltGoslingSpecUpdate?: (altSpec: AltGoslingSpec) => void; | |||
There was a problem hiding this comment.
Oh I see now! I had missed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings only the change needed to support
onAltGoslingSpecUpdatefrom #48.Usage: