New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Rotations.jl and commented out failing cxx #4

Open

sash-a wants to merge 2 commits into goretkin:master from sash-a:rotations_bugfix

sash-a commented Jul 10, 2021

Added Rotation.jl package
Commented out cxx stuff because it is failing to build right now - I think this would be useful to others who want to use it in its current state
Added .gitignore for user dependencies

A side note, I'm not sure if all those packages should have been added to the manifest, I simply called pkg.resolve(). Sorry a bit of a julia noob.

sash-a added 2 commits

July 10, 2021 19:45


          Added Rotations.jl and commented out failing cxx


          Removed cxx package

7c11da9

Owner

goretkin commented Jul 12, 2021

Thanks for the contribution. It would be great if you could split these changes into separate PRs. e.g.

disable Cxx (though I hope that package returns to working on Julia 1.6)
Use Rotations.jl directly (issue "Rotations" no longer defined on CoordinateTransformations #2), trying to migrate all uses, e.g.

Bullet.jl/src/wrap.jl

Line 183 in ed9072b

CoordinateTransformations.Rotations.Quat(w, x, y, z, false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet