-
Notifications
You must be signed in to change notification settings - Fork 174
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In addition to picking up later versions, this corrects the TOML version catalog names, and includes the android-security-lints libraries as distributed on maven now.
- Loading branch information
Showing
339 changed files
with
2,739 additions
and
1,166 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
Category | ||
: Accessibility | ||
Platform | ||
: Any | ||
: Android | ||
Vendor | ||
: Android Open Source Project | ||
Feedback | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
Category | ||
: Accessibility | ||
Platform | ||
: Any | ||
: Android | ||
Vendor | ||
: Android Open Source Project | ||
Feedback | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
Category | ||
: Accessibility | ||
Platform | ||
: Any | ||
: Android | ||
Vendor | ||
: Android Open Source Project | ||
Feedback | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
<meta charset="utf-8"> | ||
(#) Only view groups can have children | ||
|
||
!!! ERROR: Only view groups can have children | ||
This is an error. | ||
|
||
Id | ||
: `ChildInNonViewGroup` | ||
Summary | ||
: Only view groups can have children | ||
Severity | ||
: Error | ||
Category | ||
: Correctness | ||
Platform | ||
: Android | ||
Vendor | ||
: Android Open Source Project | ||
Feedback | ||
: https://issuetracker.google.com/issues/new?component=192708 | ||
Affects | ||
: Resource files | ||
Editing | ||
: This check runs on the fly in the IDE editor | ||
Implementation | ||
: [Source Code](https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-checks/src/main/java/com/android/tools/lint/checks/ChildInNonViewGroupDetector.kt) | ||
Tests | ||
: [Source Code](https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-tests/src/test/java/com/android/tools/lint/checks/ChildInNonViewGroupDetectorTest.kt) | ||
Copyright Year | ||
: 2011 | ||
|
||
Only classes inheriting from `ViewGroup` can have children. | ||
|
||
(##) Example | ||
|
||
Here is an example of lint warnings produced by this check: | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~text | ||
res/layout/wrong.xml:9:Error: A ImageView should have no children | ||
declared in XML [ChildInNonViewGroup] | ||
<TextView /> | ||
-------- | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Here is the source file referenced above: | ||
|
||
`res/layout/wrong.xml`: | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~xml linenumbers | ||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:orientation="vertical" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent"> | ||
|
||
<ImageView | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content"> | ||
<TextView /> | ||
</ImageView> | ||
|
||
</LinearLayout> | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
You can also visit the | ||
[source code](https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:lint/libs/lint-tests/src/test/java/com/android/tools/lint/checks/ChildInNonViewGroupDetectorTest.kt) | ||
for the unit tests for this check to see additional scenarios. | ||
|
||
The above example was automatically extracted from the first unit test | ||
found for this lint check, `ChildInNonViewGroupDetector.test wrong nesting of TextView within ImageView`. | ||
To report a problem with this extracted sample, visit | ||
https://issuetracker.google.com/issues/new?component=192708. | ||
|
||
(##) Suppressing | ||
|
||
You can suppress false positives using one of the following mechanisms: | ||
|
||
* Adding the suppression attribute | ||
`tools:ignore="ChildInNonViewGroup"` on the problematic XML element | ||
(or one of its enclosing elements). You may also need to add the | ||
following namespace declaration on the root element in the XML file | ||
if it's not already there: | ||
`xmlns:tools="http://schemas.android.com/tools"`. | ||
|
||
* Using a special `lint.xml` file in the source tree which turns off | ||
the check in that folder and any sub folder. A simple file might look | ||
like this: | ||
```xml | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<lint> | ||
<issue id="ChildInNonViewGroup" severity="ignore" /> | ||
</lint> | ||
``` | ||
Instead of `ignore` you can also change the severity here, for | ||
example from `error` to `warning`. You can find additional | ||
documentation on how to filter issues by path, regular expression and | ||
so on | ||
[here](https://googlesamples.github.io/android-custom-lint-rules/usage/lintxml.md.html). | ||
|
||
* In Gradle projects, using the DSL syntax to configure lint. For | ||
example, you can use something like | ||
```gradle | ||
lintOptions { | ||
disable 'ChildInNonViewGroup' | ||
} | ||
``` | ||
In Android projects this should be nested inside an `android { }` | ||
block. | ||
|
||
* For manual invocations of `lint`, using the `--ignore` flag: | ||
``` | ||
$ lint --ignore ChildInNonViewGroup ...` | ||
``` | ||
|
||
* Last, but not least, using baselines, as discussed | ||
[here](https://googlesamples.github.io/android-custom-lint-rules/usage/baselines.md.html). | ||
|
||
<!-- Markdeep: --><style class="fallback">body{visibility:hidden;white-space:pre;font-family:monospace}</style><script src="markdeep.min.js" charset="utf-8"></script><script src="https://morgan3d.github.io/markdeep/latest/markdeep.min.js" charset="utf-8"></script><script>window.alreadyProcessedMarkdeep||(document.body.style.visibility="visible")</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.