fix: ensure marker position has valid numeric coordinates. #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the condition to check if `lat` and `lng` are finite numbers before creating a `LatLng` object. This prevents potential runtime errors when lat and lng are 0.
usefulthink
force-pushed
the
fix/get-position
branch
from
8a6389d to
38a7b67
Compare
anglarett
approved these changes
Jan 30, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
Updated the condition to check if `lat` and `lng` are finite numbers before creating a `LatLng` object. This prevents potential runtime errors when lat and lng are 0. 21d62c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the condition to check if
latandlngare finite numbers before creating aLatLngobject. This prevents potential runtime errors when lat and lng are 0.Replaces: #892 and #927
Fixes: #891