Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP fix in telemetry #1572

Closed
wants to merge 1 commit into from
Closed

Conversation

mridulji
Copy link
Contributor

What this PR does / Why we need it: This PR contains the changes required for removing PSP from the telemetry sub-charts which were creating psp components in the older versions. To support the open-match on kubernetes version 1.25+ this PR will be helpful.

Which issue(s) this PR fixes:

Closes #1568
Closes #1570

Special notes for your reviewer:

  • Tested the telemetry deployment on cluster having GKE version 1.25.6-gke.200

@mridulji mridulji added the kind/bug Something isn't working label Mar 13, 2023
@scosgrave
Copy link
Collaborator

Hi @mridulji , it looks like the go.mod file needs to be updated again. All the unit tests passed in the status check, but the status check failed because of the out of date go.mod:

?   	open-match.dev/open-match/tools/reaper	[no test files]
ok  	open-match.dev/open-match/tools/reaper/internal	0.019s	coverage: 0.0% of statements [no tests to run]
cd  ./tutorials/./custom_evaluator/./director/. && GO111MODULE=on go test -p 1 -cover -test.count 10 -race ./... && GO111MODULE=on go test -p 1 -cover -test.count 10 -run IgnoreRace$ ./... 
go: updates to go.mod needed; to update it:
	go mod tidy
make: *** [Makefile:762: test] Error 1

I have verified that all the yaml created under the install directory no longer contain the PodSecurityPolicy after running make install/yaml/. I will approve this change as soon as the status check passes.

@joeholley
Copy link
Collaborator

#1581 supercedes this PR

@joeholley joeholley closed this Jul 27, 2023
@scosgrave
Copy link
Collaborator

I was going to open a PR to continue with these changes on my own branch: psp_fix_telemetry_2
@joeholley , should I abandon those changes?

@joeholley joeholley mentioned this pull request Aug 17, 2023
@joeholley joeholley mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Removing deprecation PS" not working ☹ PodSecurityPolicy In Grafana Dependency
3 participants