Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update All Go Module Dependencies to Latest Patches #4104

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

0xaravindh
Copy link
Member

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4087

Special notes for your reviewer:

@0xaravindh 0xaravindh added the dependencies Pull requests that update a dependency file label Feb 10, 2025
@0xaravindh 0xaravindh self-assigned this Feb 10, 2025
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XL labels Feb 10, 2025
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6b8eb195-605b-4682-ac68-95d3c2220b98

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@0xaravindh
Copy link
Member Author

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 8ae3454e-45fe-4458-8a2a-eabe4d3e941b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 16f38d48-8dcc-4d43-aea5-546aaf5d0bcc

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Collaborator

igooch commented Feb 10, 2025

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 573aa8f1-6aae-4cf1-b1fc-0a13fa8a57fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch mentioned this pull request Feb 10, 2025
@igooch
Copy link
Collaborator

igooch commented Feb 10, 2025

Updated example images with the same tags have been pushed to the agones examples repo. Merging this PR per #4106 passing without the example images test.

Adding a note that in the future we'll likely want to bump the image version at the same time as the dependency upgrades.

Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igooch igooch merged commit 9597469 into googleforgames:main Feb 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/cleanup Refactoring code, fixing up documentation, etc size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies in all go.mod files
3 participants